linux-kernel - Re: [PATCH v3 1/1] x86: Fix Intel Edison module stuck reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeANMZ58R6qj4Ue8xyvmALFFNaUG0XPS=AVMK8HHjFVvQ@mail.gmail.com>
Date:   Wed, 28 Feb 2018 12:47:42 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Sebastian Panceac <sebastian@...in.io>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        x86@...nel.org
Subject: Re: [PATCH v3 1/1] x86: Fix Intel Edison module stuck reboot

On Wed, Feb 28, 2018 at 11:40 AM, Sebastian Panceac <sebastian@...in.io> wrote:
> When powering Intel Edison module with 3.3V, the "reboot" command makes
> the module stuck.
> If the module is powered at a greater voltage, like 4.4V (as the Edison
> Mini Breakout board does), reboot works OK.
>
> This patch copies the behaviour from the official Intel Edison BSP,
> where "IPCMSG_COLD_RESET" message was sent to SCU by default at
> reboot time.
>
> In the official BSP, sending the "IPCMSG_COLD_BOOT" message instead of
> "IPCMSG_COLD_RESET" was possible, by using a kernel command
> line parameter.
>

Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Sebastian Panceac <sebastian@...in.io>
> ---
>
> Hi,
>
> I submitted again the patch, after taking into consideration Andy's suggestions.
>
> Regards!
>
>  arch/x86/platform/intel-mid/intel-mid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/platform/intel-mid/intel-mid.c b/arch/x86/platform/intel-mid/intel-mid.c
> index 2c67bae..fb1df94 100644
> --- a/arch/x86/platform/intel-mid/intel-mid.c
> +++ b/arch/x86/platform/intel-mid/intel-mid.c
> @@ -79,7 +79,7 @@ static void intel_mid_power_off(void)
>
>  static void intel_mid_reboot(void)
>  {
> -       intel_scu_ipc_simple_command(IPCMSG_COLD_BOOT, 0);
> +       intel_scu_ipc_simple_command(IPCMSG_COLD_RESET, 0);
>  }
>
>  static unsigned long __init intel_mid_calibrate_tsc(void)
> --
> 2.7.4



-- 
With Best Regards,
Andy Shevchenko