[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180301212844.GU12864@sirena.org.uk>
Date: Thu, 1 Mar 2018 21:28:44 +0000
From: Mark Brown <broonie@...nel.org>
To: srinivas.kandagatla@...aro.org
Cc: andy.gross@...aro.org, linux-arm-msm@...r.kernel.org,
alsa-devel@...a-project.org, david.brown@...aro.org,
robh+dt@...nel.org, mark.rutland@....com, lgirdwood@...il.com,
plai@...eaurora.org, bgoswami@...eaurora.org, perex@...ex.cz,
tiwai@...e.com, linux-soc@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, rohkumar@....qualcomm.com,
spatakok@....qualcomm.com
Subject: Re: [PATCH v3 10/25] ASoC: qcom: q6asm: Add support to memory map
and unmap
On Tue, Feb 13, 2018 at 04:58:22PM +0000, srinivas.kandagatla@...aro.org wrote:
> + num_regions = is_contiguous ? 1 : periods;
> + buf_sz = is_contiguous ? (period_sz * periods) : period_sz;
Please write normal if statements, it's much easier to read.
> + buf_sz = PAGE_ALIGN(buf_sz);
I don't understand what this is doing, buf_sz is a length not an address
so why are we attempting to align it?
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists