linux-kernel - Re: [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180302225734.GE31240@lst.de>
Date:   Fri, 2 Mar 2018 23:57:34 +0100
From:   Christoph Hellwig <hch@....de>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     Christoph Hellwig <hch@....de>,
        linux-nvdimm <linux-nvdimm@...ts.01.org>,
        linux-xfs <linux-xfs@...r.kernel.org>,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        KVM list <kvm@...r.kernel.org>,
        Haozhong Zhang <haozhong.zhang@...el.com>,
        Jane Chu <jane.chu@...cle.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Gerd Rausch <gerd.rausch@...cle.com>,
        stable <stable@...r.kernel.org>, Jan Kara <jack@...e.cz>,
        Michal Hocko <mhocko@...e.com>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        Ross Zwisler <ross.zwisler@...ux.intel.com>,
        Matthew Wilcox <mawilcox@...rosoft.com>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Alex Williamson <alex.williamson@...hat.com>,
        Theodore Ts'o <tytso@....edu>, Linux MM <linux-mm@...ck.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax
        pins and other fixes

On Fri, Mar 02, 2018 at 02:21:40PM -0800, Dan Williams wrote:
> They are indeed a hodge-podge. The problem is that the current
> IS_DAX() is broken. So I'd like to propose fixing IS_DAX() with
> IS_FSDAX() + IS_DEVDAX() for 4.16-rc4 and queue up these wider reworks
> you propose for the next merge window.

The only thing broken about IS_DAX are the code elimination games
based on the CONFIG_* flags.  Remove those and just add proper stubs
for the dax routines and everything will be fine for now until we can
kill that inode flag.

IS_FSDAX and IS_DEVDAX on the other hand are a giant mess that isn't
helping anyone.