linux-kernel - Re: [PATCH v2 2/2] ARM: ftrace: Add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180302120026.52f34ad2@vmware.local.home>
Date:   Fri, 2 Mar 2018 12:00:26 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Alexander Sverdlin <alexander.sverdlin@...ia.com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Russell King <linux@...linux.org.uk>,
        Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH v2 2/2] ARM: ftrace: Add MODULE_PLTS support

On Thu,  1 Mar 2018 17:43:43 +0100
Alexander Sverdlin <alexander.sverdlin@...ia.com> wrote:

> diff --git a/arch/arm/include/asm/ftrace.h b/arch/arm/include/asm/ftrace.h
> index 9e842ff..3e663f9 100644
> --- a/arch/arm/include/asm/ftrace.h
> +++ b/arch/arm/include/asm/ftrace.h
> @@ -19,6 +19,7 @@ struct dyn_arch_ftrace {
>  #ifdef CONFIG_OLD_MCOUNT
>  	bool	old_mcount;
>  #endif

I think you want to add:

#ifdef CONFIG_ARM_MODULE_PLTS
> +	struct module *mod;
#endif

This will add more memory overhead, and we don't want to add that if it
is not needed.

-- Steve