linux-kernel - Re: [PATCH v2 2/2] ARM: ftrace: Add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8aa72633-5323-7f85-d326-6b7231b12aeb@nokia.com>
Date:   Mon, 5 Mar 2018 10:18:56 +0100
From:   Alexander Sverdlin <alexander.sverdlin@...ia.com>
To:     Steven Rostedt <rostedt@...dmis.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        Russell King <linux@...linux.org.uk>,
        Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH v2 2/2] ARM: ftrace: Add MODULE_PLTS support

Hello Steven!

On 02/03/18 18:00, Steven Rostedt wrote:
>> diff --git a/arch/arm/include/asm/ftrace.h b/arch/arm/include/asm/ftrace.h
>> index 9e842ff..3e663f9 100644
>> --- a/arch/arm/include/asm/ftrace.h
>> +++ b/arch/arm/include/asm/ftrace.h
>> @@ -19,6 +19,7 @@ struct dyn_arch_ftrace {
>>  #ifdef CONFIG_OLD_MCOUNT
>>  	bool	old_mcount;
>>  #endif
> I think you want to add:
> 
> #ifdef CONFIG_ARM_MODULE_PLTS
>> +	struct module *mod;
> #endif
> 
> This will add more memory overhead, and we don't want to add that if it
> is not needed.

Will include it into the next version.
Thanks for the review!

-- 
Best regards,
Alexander Sverdlin.