linux-kernel - Re: [PATCH 2/2] IB/qib: Move char *qib_sdma_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 3 Mar 2018 10:31:48 -0500
From:   Dennis Dalessandro <dennis.dalessandro@...el.com>
To:     Hernán Gonzalez <hernan@...guardiasur.com.ar>,
        mike.marciniszyn@...el.com, dledford@...hat.com, jgg@...pe.ca,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] IB/qib: Move char *qib_sdma_state_names[] and
 constify while there.

On 2/27/2018 5:05 PM, Hernán Gonzalez wrote:
> Note: This is compile only tested as I have no access to the hw.
> This variable was not used in qib_sdma.c but in qib_iba7322.c. Declaring it
> there, as static, saves 56 bytes.
> 
> add/remove: 0/2 grow/shrink: 0/0 up/down: 0/-144 (-144)
> Function                                     old     new   delta
> qib_sdma_state_names                          56       -     -56
> qib_sdma_event_names                          88       -     -88
> Total: Before=2874565, After=2874421, chg -0.01%
> 
> Signed-off-by: Hernán Gonzalez <hernan@...guardiasur.com.ar>

Looks OK to me, thanks.

Reviewed-by: Dennis Dalessandro <dennis.dalessandro@...el.com>