linux-kernel - Re: [PATCH] infiniband: hw: Drop unnecessary continue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 3 Mar 2018 10:32:52 -0500
From:   Dennis Dalessandro <dennis.dalessandro@...el.com>
To:     Arushi Singhal <arushisinghal19971997@...il.com>
Cc:     mike.marciniszyn@...el.com, Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [PATCH] infiniband: hw: Drop unnecessary continue

On 3/3/2018 8:03 AM, Arushi Singhal wrote:
> Continue at the bottom of a loop are removed.
> Issue found using drop_continue.cocci Coccinelle script.
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@...il.com>
> ---
>   drivers/infiniband/hw/qib/qib_init.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c
> index 3990f38..1bd3b32 100644
> --- a/drivers/infiniband/hw/qib/qib_init.c
> +++ b/drivers/infiniband/hw/qib/qib_init.c
> @@ -681,7 +681,6 @@ int qib_init(struct qib_devdata *dd, int reinit)
>   		if (lastfail) {
>   			qib_dev_err(dd,
>   				"failed to allocate kernel ctxt's rcvhdrq and/or egr bufs\n");
> -			continue;
>   		}
>   	}
>   
> 

Please run checkpatch before posting patches. This will fail as you left 
braces around a single line.

-Denny