linux-kernel - Re: [PATCH 2/3] crypto: ccp - return an actual key size from RSA max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Mar 2018 18:16:09 -0600
From:   Gary R Hook <gary.hook@....com>
To:     "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>,
        "Hook, Gary" <ghook@....com>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        David Howells <dhowells@...hat.com>,
        Tom Lendacky <thomas.lendacky@....com>,
        keyrings@...r.kernel.org, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] crypto: ccp - return an actual key size from RSA
 max_size callback

On 03/02/2018 05:58 PM, Maciej S. Szmigiero wrote:
> On 03.03.2018 00:49, Hook, Gary wrote:
>> On 3/2/2018 5:15 PM, Maciej S. Szmigiero wrote:
>>>
>>> Thanks.
>>>
>>> However, what about the first patch from this series?
>>> Without it, while it no longer should cause a buffer overflow, in-kernel
>>> X.509 certificate verification will still fail with CCP driver loaded
>>> (since CCP RSA implementation has a higher priority than the software
>>> RSA implementation).
>>>
>>> Maciej
>>>
>>
>>
>> I commented on that one here:
>> https://marc.info/?l=linux-crypto-vger&m=151986452422791&w=2
>>
>> Effectively a NACK. We are a reviewing a proposed patch right now.
> 
> Your earlier comment referred to the third patch from this series.
> My message above was about the first one.

Apologies; my mistake.