linux-kernel - Re: [PATCH 4.4 64/67] usb: uas: unconditionally bring back host after reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 03 Mar 2018 00:19:24 +0000
From:   Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:     Oliver Neukum <oneukum@...e.com>,
        Hans de Goede <hdegoede@...hat.com>
Cc:     stable@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4.4 64/67] usb: uas: unconditionally bring back host
 after reset

On Fri, 2018-02-02 at 17:58 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Oliver Neukum <oneukum@...e.com>
> 
> commit cbeef22fd611c4f47c494b821b2b105b8af970bb upstream.
[...]
> --- a/drivers/usb/storage/uas.c
> +++ b/drivers/usb/storage/uas.c
> @@ -1052,20 +1052,19 @@ static int uas_post_reset(struct usb_int
>  		return 0;
>  
> 	err = uas_configure_endpoints(devinfo);
> -	if (err) {
> +	if (err && err != ENODEV)
>  		shost_printk(KERN_ERR, shost,
>  			     "%s: alloc streams error %d after reset",
>  			     __func__, err);
[...]

This should be checking for -ENODEV, shouldn't it?

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.