linux-kernel - Re: [PATCH] PCI: Move declaration of of_irq_parse_and_map_pci under OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180305231936.GA14751@roeck-us.net>
Date:   Mon, 5 Mar 2018 15:19:36 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Rob Herring <robh@...nel.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Frank Rowand <frowand.list@...il.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: Move declaration of of_irq_parse_and_map_pci under
 OF_IRQ

On Mon, Mar 05, 2018 at 03:57:37PM -0600, Rob Herring wrote:
> On Mon, Feb 26, 2018 at 03:19:05PM -0800, Guenter Roeck wrote:
> > Since commit 4670d610d5923 ("PCI: Move OF-related PCI functions into
> > PCI core"), sparc:allmodconfig fails to build with the following error.
> > 
> > pcie-cadence-host.c:(.text+0x4c4):
> > 	undefined reference to `of_irq_parse_and_map_pci'
> > pcie-cadence-host.c:(.text+0x4c8):
> > 	undefined reference to `of_irq_parse_and_map_pci'
> > 
> > of_irq_parse_and_map_pci is now only available if OF_IRQ is enabled.
> > Make its declaration and its dummy function dependent on OF_IRQ
> > to solve the problem.
> > 
> > Fixes: 4670d610d5923 ("PCI: Move OF-related PCI functions into PCI core")
> > Cc: Rob Herring <robh@...nel.org>
> > Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> > ---
> >  include/linux/of_pci.h | 17 ++++++++++-------
> >  1 file changed, 10 insertions(+), 7 deletions(-)
> 
> Bjorn should take this. Can you resend to linux-pci so it is in his 
> queue.
> 
MAINTAINERS lists you as maintainer and devicetree@...r.kernel.org as
mailing list. But, sure, no problem.

Guenter