linux-kernel - Re: [PATCH v2] mmc: Export host capabilities to debugfs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40000048-4f64-792d-ba38-25a15be8569a@rock-chips.com>
Date:   Mon, 5 Mar 2018 15:51:54 +0800
From:   Shawn Lin <shawn.lin@...k-chips.com>
To:     Harish Jenny K N <harish_kandiga@...tor.com>,
        ulf.hansson@...aro.org, linus.walleij@...aro.org,
        adrian.hunter@...el.com, avri.altman@....com,
        andriy.shevchenko@...ux.intel.com
Cc:     shawn.lin@...k-chips.com, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org, Vladimir_Zapolskiy@...tor.com
Subject: Re: [PATCH v2] mmc: Export host capabilities to debugfs.

On 2018/3/5 12:24, Harish Jenny K N wrote:
> From: Abbas Raza <Abbas_Raza@...tor.com>
> 
> This patch exports the host capabilities to debugfs
> 
> Signed-off-by: Abbas Raza <Abbas_Raza@...tor.com>
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@...tor.com>
> Signed-off-by: Harish Jenny K N <harish_kandiga@...tor.com>
> ---
> 
> Changes in v2:
> - Changed Author
> 
>   drivers/mmc/core/debugfs.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
> index c51e0c0..fa2df7f 100644
> --- a/drivers/mmc/core/debugfs.c
> +++ b/drivers/mmc/core/debugfs.c
> @@ -289,6 +289,9 @@ void mmc_add_card_debugfs(struct mmc_card *card)
>   
>   	card->debugfs_root = root;
>   
> +	if (!debugfs_create_x32("host_caps", S_IRUSR, root, (u32 *)&host->caps))

Perhaps you don't need cast, and '&host->caps' should be fine?
And you don't need to export host->caps2?

> +		goto err;
> +
>   	if (!debugfs_create_x32("state", S_IRUSR, root, &card->state))
>   		goto err;
>   
>