linux-kernel - Re: [PATCH v2] mmc: Export host capabilities to debugfs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <da6cffcc-28d6-9a50-c887-4c4a5903c09c@mentor.com>
Date:   Mon, 5 Mar 2018 14:48:16 +0530
From:   Harish Jenny K N <harish_kandiga@...tor.com>
To:     Shawn Lin <shawn.lin@...k-chips.com>, <ulf.hansson@...aro.org>,
        <linus.walleij@...aro.org>, <adrian.hunter@...el.com>,
        <avri.altman@....com>, <andriy.shevchenko@...ux.intel.com>
CC:     <linux-mmc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <Vladimir_Zapolskiy@...tor.com>
Subject: Re: [PATCH v2] mmc: Export host capabilities to debugfs.



On Monday 05 March 2018 01:21 PM, Shawn Lin wrote:
> On 2018/3/5 12:24, Harish Jenny K N wrote:
>> From: Abbas Raza <Abbas_Raza@...tor.com>
>>
>> This patch exports the host capabilities to debugfs
>>
>> Signed-off-by: Abbas Raza <Abbas_Raza@...tor.com>
>> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@...tor.com>
>> Signed-off-by: Harish Jenny K N <harish_kandiga@...tor.com>
>> ---
>>
>> Changes in v2:
>> - Changed Author
>>
>>   drivers/mmc/core/debugfs.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
>> index c51e0c0..fa2df7f 100644
>> --- a/drivers/mmc/core/debugfs.c
>> +++ b/drivers/mmc/core/debugfs.c
>> @@ -289,6 +289,9 @@ void mmc_add_card_debugfs(struct mmc_card *card)
>>         card->debugfs_root = root;
>>   +    if (!debugfs_create_x32("host_caps", S_IRUSR, root, (u32 *)&host->caps))
>
> Perhaps you don't need cast, and '&host->caps' should be fine?

Yes. I will send updated patch.
> And you don't need to export host->caps2?

I will send this is as a separate patch, as this also requires changes in mmc-utils sample application to parse the value.


Thanks,
Harish Jenny K N