linux-kernel - Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Amlogic Meson GX SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be7cad05-ab4a-572b-1535-fbd85ea7c386@codeaurora.org>
Date:   Tue, 6 Mar 2018 15:54:57 +0530
From:   Archit Taneja <architt@...eaurora.org>
To:     Neil Armstrong <narmstrong@...libre.com>
Cc:     airlied@...ux.ie, a.hajda@...sung.com, Jose.Abreu@...opsys.com,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Amlogic
 Meson GX SoCs

Hi,

On Tuesday 06 March 2018 03:23 PM, Neil Armstrong wrote:
> Hi Architt,
> 
> On 23/02/2018 12:44, Neil Armstrong wrote:
>> The Amlogic Meson GX SoCs, embedded the v2.01a controller, has been also
>> identified needing this workaround.
>> This patch adds the corresponding version to enable a single iteration for
>> this specific version.
>>
>> Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based on device version")
>> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
>> ---
>>   drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> index a38db40..f5018f9 100644
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> @@ -1637,6 +1637,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
>>   	 * (and possibly on the platform). So far only i.MX6Q (v1.30a) and
>>   	 * i.MX6DL (v1.31a) have been identified as needing the workaround, with
>>   	 * 4 and 1 iterations respectively.
>> +	 * The Amlogic Meson GX SoCs (v2.01a) have been identifies as needing
>> +	 * the workaround with a single iteration.

s/identifies/identified

>>   	 */
>>   
>>   	switch (hdmi->version) {
>> @@ -1644,6 +1646,7 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
>>   		count = 4;
>>   		break;
>>   	case 0x131a:
>> +	case 0x201a:
>>   		count = 1;
>>   		break;
>>   	default:
>>
> 
> This fixes a long time issue on Amlogic SoCs, is it ok for you ?

Looks good to me. Feel free to queue it to drm-misc-next.

Thanks,
Archit

> 
> Thanks,
> Neil
>