linux-kernel - Re: [PATCH v4 1/3] Input: gpio-keys - add support for wakeup event action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcmbHbnD8FnTHXAqGajhs10wA7Z7U_D6SY9=j=y+GLLPA@mail.gmail.com>
Date:   Wed, 7 Mar 2018 13:57:17 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jeffy Chen <jeffy.chen@...k-chips.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        briannorris@...gle.com,
        Heiko Stübner <heiko@...ech.de>,
        Dmitry Torokhov <dtor@...gle.com>,
        Douglas Anderson <dianders@...gle.com>,
        devicetree <devicetree@...r.kernel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Joseph Lo <josephl@...dia.com>,
        stephen lu <lumotuwe@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        linux-input <linux-input@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mark Rutland <mark.rutland@....com>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Arvind Yadav <arvind.yadav.cs@...il.com>
Subject: Re: [PATCH v4 1/3] Input: gpio-keys - add support for wakeup event action

On Tue, Mar 6, 2018 at 9:44 AM, Jeffy Chen <jeffy.chen@...k-chips.com> wrote:
> Add support for specifying event actions to trigger wakeup when using
> the gpio-keys input device as a wakeup source.
>
> This would allow the device to configure when to wakeup the system. For
> example a gpio-keys input device for pen insert, may only want to wakeup
> the system when ejecting the pen.

> +       bool wakeup_enabled;

> +                       if (bdata->wakeup_enabled) {

This is redundant. IRQ core keeps track on this information already.

Check below as an example
aef3ad103a68 ("serial: core: remove unneeded irq_wake flag")


-- 
With Best Regards,
Andy Shevchenko