[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5AA0E6F9.6060704@rock-chips.com>
Date: Thu, 08 Mar 2018 15:32:09 +0800
From: JeffyChen <jeffy.chen@...k-chips.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
CC: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
briannorris@...gle.com,
Heiko Stübner <heiko@...ech.de>,
Dmitry Torokhov <dtor@...gle.com>,
Douglas Anderson <dianders@...gle.com>,
devicetree <devicetree@...r.kernel.org>,
Guenter Roeck <linux@...ck-us.net>,
Thomas Gleixner <tglx@...utronix.de>,
Joseph Lo <josephl@...dia.com>,
stephen lu <lumotuwe@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Kate Stewart <kstewart@...uxfoundation.org>,
linux-input <linux-input@...r.kernel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Mark Rutland <mark.rutland@....com>,
Philippe Ombredanne <pombredanne@...b.com>,
Arvind Yadav <arvind.yadav.cs@...il.com>
Subject: Re: [PATCH v4 1/3] Input: gpio-keys - add support for wakeup event
action
Hi Andy,
Thanks for your reply.
On 03/07/2018 07:57 PM, Andy Shevchenko wrote:
> On Tue, Mar 6, 2018 at 9:44 AM, Jeffy Chen <jeffy.chen@...k-chips.com> wrote:
>> Add support for specifying event actions to trigger wakeup when using
>> the gpio-keys input device as a wakeup source.
>>
>> This would allow the device to configure when to wakeup the system. For
>> example a gpio-keys input device for pen insert, may only want to wakeup
>> the system when ejecting the pen.
>
>> + bool wakeup_enabled;
>
>> + if (bdata->wakeup_enabled) {
>
> This is redundant. IRQ core keeps track on this information already.
>
> Check below as an example
> aef3ad103a68 ("serial: core: remove unneeded irq_wake flag")
>
right, that make sense.
>
Powered by blists - more mailing lists