linux-kernel - Re: [PATCH] cxgb3: remove VLA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2dbb7aba-4e12-c4df-363e-b65fcbb16d0e@embeddedor.com>
Date:   Wed, 7 Mar 2018 11:30:39 -0600
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     David Miller <davem@...emloft.net>, gustavo@...eddedor.com
Cc:     santosh@...lsio.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cxgb3: remove VLA



On 03/07/2018 11:25 AM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
> Date: Mon, 5 Mar 2018 23:39:34 -0600
> 
>> In preparation to enabling -Wvla, remove VLA and replace it
>> with dynamic memory allocation.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> 
> All of these lengths are limited by the encoding of the field in the
> VPD, which is a u8, and thus 255 bytes.
> 
> Please just change the 'len' argument to these functions to a u8 and
> use a 256 byte buffer on the stack.
> 
> Thanks.
> 


OK. I got it.

Thanks for the feedback.
--
Gustavo