linux-kernel - Re: [PATCH 2/6] lib/scatterlist: Skip requesting zeroed allocations in sgl_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90d6f5e3-7480-46a9-8803-12ffe7db4343@ursulin.net>
Date:   Wed, 7 Mar 2018 17:31:11 +0000
From:   Tvrtko Ursulin <tursulin@...ulin.net>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Tvrtko Ursulin <tvrtko.ursulin@...el.com>,
        Bart Van Assche <bart.vanassche@....com>,
        Hannes Reinecke <hare@...e.com>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH 2/6] lib/scatterlist: Skip requesting zeroed allocations
 in sgl_alloc_order


On 07/03/18 15:35, Andy Shevchenko wrote:
> On Wed, Mar 7, 2018 at 2:47 PM, Tvrtko Ursulin <tursulin@...ulin.net> wrote:
> 
>> +       sgl = kmalloc_array(nent, sizeof(struct scatterlist), (gfp & ~GFP_DMA));
> 
> The parens now become redundant.

True thanks! I am also not sure that re-using the same gfp_t for 
metadata is backing store is the right approach. At least I think 
__GFP_HIGHMEM needs also to be cleared for kmalloc.

Regards,

Tvrtko