linux-kernel - Re: [PATCH] vsprintf: Remove accidental VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKvAiyF=Dxd0nGx6bH84Vjqksjf4jZRXOTVXqSrnG6S5A@mail.gmail.com>
Date:   Wed, 7 Mar 2018 16:36:17 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Tycho Andersen <tycho@...ho.ws>, "Tobin C. Harding" <me@...in.cc>,
        Jonathan Corbet <corbet@....net>,
        Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Kernel Hardening <kernel-hardening@...ts.openwall.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: Re: [PATCH] vsprintf: Remove accidental VLA usage

On Wed, Mar 7, 2018 at 4:03 PM, Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Wed, 7 Mar 2018 15:59:27 -0800 Kees Cook <keescook@...omium.org> wrote:
>
>> I didn't want to encourage a global macro that _lacked_ the safety
>> built into the max*() family, though... thoughts for a reasonable
>> approach?
>
> I think SIMPLE_MAX() is OK.    Along with one of /* these */ things ;)

Sounds good. I will resend with net/ipv[46]/proc.c and one other fixed
as well...

-Kees

-- 
Kees Cook
Pixel Security