linux-kernel - Re: [PATCH] vsprintf: Remove accidental VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180307160322.e9f8a3fb462751d1efa3b09a@linux-foundation.org>
Date:   Wed, 7 Mar 2018 16:03:22 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Tycho Andersen <tycho@...ho.ws>, "Tobin C. Harding" <me@...in.cc>,
        Jonathan Corbet <corbet@....net>,
        Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Kernel Hardening <kernel-hardening@...ts.openwall.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: Re: [PATCH] vsprintf: Remove accidental VLA usage

On Wed, 7 Mar 2018 15:59:27 -0800 Kees Cook <keescook@...omium.org> wrote:

> I didn't want to encourage a global macro that _lacked_ the safety
> built into the max*() family, though... thoughts for a reasonable
> approach?

I think SIMPLE_MAX() is OK.    Along with one of /* these */ things ;)