linux-kernel - Re: [PATCH] bfa: remove VLA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180309231542.3eb53b87@heffalump.sk2.org>
Date:   Fri, 9 Mar 2018 23:15:42 +0100
From:   Stephen Kitt <steve@....org>
To:     Anil Gurumurthy <anil.gurumurthy@...gic.com>,
        Sudarsana Kalluru <sudarsana.kalluru@...gic.com>
Cc:     linux-scsi@...r.kernel.org,
        Kernel Hardening <kernel-hardening@...ts.openwall.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bfa: remove VLA

Hi,

I sent this to the wrong maintainers, sorry — you’ll find the original patch
on https://patchwork.kernel.org/patch/10269257/

Regards,

Stephen


On Thu, 8 Mar 2018 13:43:07 -0800, Kees Cook <keescook@...omium.org> wrote:
> On Thu, Mar 8, 2018 at 1:38 PM, Stephen Kitt <steve@....org> wrote:
> > In preparation to enabling -Wvla, remove VLAs and replace them with
> > fixed-length arrays instead.
> >
> > bfad_bsg.c uses a variable-length array declaration to measure the
> > size of a putative array; this can be replaced by the product of the
> > size of an element and the number of elements, avoiding the VLA
> > altogether.
> >
> > This was prompted by https://lkml.org/lkml/2018/3/7/621
> >
> > Signed-off-by: Stephen Kitt <steve@....org>  
> 
> Reviewed-by: Kees Cook <keescook@...omium.org>
> 
> -Kees
> 
> > ---
> >  drivers/scsi/bfa/bfad_bsg.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c
> > index 3976e787ba64..7c884f881180 100644
> > --- a/drivers/scsi/bfa/bfad_bsg.c
> > +++ b/drivers/scsi/bfa/bfad_bsg.c
> > @@ -891,7 +891,7 @@ bfad_iocmd_fabric_get_lports(struct bfad_s *bfad,
> > void *cmd,
> >
> >         if (bfad_chk_iocmd_sz(payload_len,
> >                 sizeof(struct bfa_bsg_fabric_get_lports_s),
> > -               sizeof(wwn_t[iocmd->nports])) != BFA_STATUS_OK) {
> > +               sizeof(wwn_t) * iocmd->nports) != BFA_STATUS_OK) {
> >                 iocmd->status = BFA_STATUS_VERSION_FAIL;
> >                 goto out;
> >         }
> > --
> > 2.11.0
> >  
> 
> 
> 
> -- 
> Kees Cook
> Pixel Security

Content of type "application/pgp-signature" skipped