linux-kernel - Re: [PATCH] arm64: defconfig: enable Rockchip io-domain driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5be003fc-7b86-6d49-278a-1297891212d6@arm.com>
Date:   Fri, 9 Mar 2018 12:49:41 +0000
From:   Robin Murphy <robin.murphy@....com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Heiko Stuebner <heiko@...ech.de>
Cc:     kernel@...labora.com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm64: defconfig: enable Rockchip io-domain driver

On 08/03/18 21:35, Enric Balletbo i Serra wrote:
> Heiko Stübner justified pretty well the change in commit e330eb86ba0
> 'ARM: multi_v7_defconfig: enable Rockchip io-domain driver'. This change
> is also needed for arm64 rockchip boards, so, do the same for arm64.
> 
> The io-domain driver is necessary to notify the soc about voltages
> changes happening on supplying regulators. Probably the most important
> user right now is the mmc tuning code, where the soc needs to get
> notified when the voltage is dropped to the 1.8V point.
> 
> As this option is necessary to successfully tune UHS cards etc, it
> should get built in. Otherwise, tunning will fail with,
> 
>     dwmmc_rockchip fe320000.dwmmc: All phases bad!
>     mmc0: tuning execution failed: -5

It also causes ethernet to fail in a rather odd manner if your board 
needs RGMII at <3.3v but you're using firmware which leaves the relevant 
IO domain set inappropriately (I guess the parts expecting to be driven 
by the external phy clock just lock up). Given the several hours I spent 
scratching my head over that one,

Acked-by: Robin Murphy <robin.murphy@....com>

> Cc: Heiko Stübner <heiko@...ech.de>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> ---
>   arch/arm64/configs/defconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index ba859709c2d4..d65d53b1ff77 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -313,6 +313,8 @@ CONFIG_GPIO_XGENE_SB=y
>   CONFIG_GPIO_PCA953X=y
>   CONFIG_GPIO_PCA953X_IRQ=y
>   CONFIG_GPIO_MAX77620=y
> +CONFIG_POWER_AVS=y
> +CONFIG_ROCKCHIP_IODOMAIN=y
>   CONFIG_POWER_RESET_MSM=y
>   CONFIG_POWER_RESET_XGENE=y
>   CONFIG_POWER_RESET_SYSCON=y
>