linux-kernel - Re: [PATCH] perf tools arm64: Add libdw DWARF post unwind support for ARM64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180309182440.GA25111@kernel.org>
Date:   Fri, 9 Mar 2018 15:24:40 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Kim Phillips <kim.phillips@....com>, Jiri Olsa <jolsa@...nel.org>
Cc:     "Christian Hansen (chansen3)" <chansen3@...co.com>,
        "linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        "Vuille, Martin (Martin)" <vmartin@...ya.com>,
        Martin Vuille <jpmv27@....com>
Subject: Re: [PATCH] perf tools arm64: Add libdw DWARF post unwind support
 for ARM64

Em Fri, Mar 09, 2018 at 12:07:20PM -0600, Kim Phillips escreveu:
> On Fri, 9 Mar 2018 12:06:27 -0300
> Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> 
> Hi Arnaldo,
> 
> > Em Thu, Mar 08, 2018 at 09:10:30PM -0600, Kim Phillips escreveu:
> > > Based on prior work:
> > > 
> > > https://lkml.org/lkml/2014/5/6/395
> > 
> > Thanks, looks good, applying.
> > 
> > Jean, is everything ok with you on this?
> 
> By now your email to Jean should have bounced with "The email account
> that you tried to reach does not exist."  Removing Jean from Cc.
> 
> It seems like you're applying patches.  There are a couple that have
> slipped through the cracks: Can you please take a look at applying them?
> 
> - "perf tools: Fixing uninitialised variable"
>   https://patchwork.kernel.org/patch/10179381/

[acme@...et perf]$ git tag --contains d2785de15f1bd42d613d56bbac5a007e7293b874
perf-core-for-mingo-4.17-20180216

commit d2785de15f1bd42d613d56bbac5a007e7293b874
Author:     Mathieu Poirier <mathieu.poirier@...aro.org>
AuthorDate: Mon Feb 12 13:32:37 2018 -0700
Commit:     Arnaldo Carvalho de Melo <acme@...hat.com>
CommitDate: Fri Feb 16 14:55:40 2018 -0300

    perf auxtrace arm: Fixing uninitialised variable
    
    When working natively on arm64 the compiler gets pesky and complains
    that variable 'i' is uninitialised, something that breaks the
    compilation.  Here no further checks are needed since variable
    'found_spe' can only be true if variable 'i' has been initialised as
    part of the for loop.
    
    Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>
    Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
    Cc: Jin Yao <yao.jin@...ux.intel.com>
    Cc: Namhyung Kim <namhyung@...nel.org>
    Cc: Peter Zijlstra <peterz@...radead.org>
    Cc: linux-arm-kernel@...ts.infradead.org
    Link: http://lkml.kernel.org/r/1518467557-18505-4-git-send-email-mathieu.poirier@linaro.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>

diff --git a/tools/perf/arch/arm/util/auxtrace.c b/tools/perf/arch/arm/util/auxtrace.c
index 2323581b157d..fa639e3e52ac 100644
--- a/tools/perf/arch/arm/util/auxtrace.c
+++ b/tools/perf/arch/arm/util/auxtrace.c
@@ -68,7 +68,7 @@ struct auxtrace_record
        bool found_spe = false;
        static struct perf_pmu **arm_spe_pmus = NULL;
        static int nr_spes = 0;
-       int i;
+       int i = 0;
 
> - "perf unwind: Report error from dwfl_attach_state"
>   https://patchwork.kernel.org/patch/10211483/
>   [Martin, I guess it would help if you replied-all that patch and
>    added your signed-off-by.]

Right, the S-o-B is needed
 
> - "perf unwind: Unwind with libdw doesn't take symfs into account"
>   https://patchwork.kernel.org/patch/10211599/

This one has the S-o-B, applying, Jiri, holler if you disagree,

- Arnaldo
 
> Thanks,
> 
> Kim