linux-kernel - Re: [PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle CLOCK_MONOTONIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 11 Mar 2018 23:53:47 -0700 (PDT)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Jason Vas Dias <jason.vas.dias@...il.com>
cc:     x86@...nel.org, LKML <linux-kernel@...r.kernel.org>,
        andi <andi@...stfloor.org>, Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle
 CLOCK_MONOTONIC_RAW

On Mon, 12 Mar 2018, Jason Vas Dias wrote:

checkpatch.pl still reports:

   total: 15 errors, 3 warnings, 165 lines checked

> +notrace static u64 vread_tsc_raw(void)
> +{
> +	u64 tsc, last=gtod->raw_cycle_last;
> +	if( likely( gtod->has_rdtscp ) )
> +		tsc	= rdtscp((void*)0);

Plus I asked more than once to split that rdtscp() stuff into a separate
patch.

You surely are free to ignore my review comments, but rest assured that I'm
free to ignore the crap you insist to send me as well.

Thanks,

	tglx