linux-kernel - Re: [PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle CLOCK_MONOTONIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180312072413.toyd5ztkgaah35xg@gmail.com>
Date:   Mon, 12 Mar 2018 08:24:13 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Jason Vas Dias <jason.vas.dias@...il.com>, x86@...nel.org,
        LKML <linux-kernel@...r.kernel.org>, andi <andi@...stfloor.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle
 CLOCK_MONOTONIC_RAW


* Thomas Gleixner <tglx@...utronix.de> wrote:

> On Mon, 12 Mar 2018, Jason Vas Dias wrote:
> 
> checkpatch.pl still reports:
> 
>    total: 15 errors, 3 warnings, 165 lines checked
> 
> > +notrace static u64 vread_tsc_raw(void)
> > +{
> > +	u64 tsc, last=gtod->raw_cycle_last;
> > +	if( likely( gtod->has_rdtscp ) )
> > +		tsc	= rdtscp((void*)0);
> 
> Plus I asked more than once to split that rdtscp() stuff into a separate
> patch.
> 
> You surely are free to ignore my review comments, but rest assured that I'm
> free to ignore the crap you insist to send me as well.

In addition to Thomas's review feedback I'd strongly urge the careful reading of 
Documentation/SubmittingPatches as well:

 - When sending multiple patches please use git-send-mail

 - Please don't send several patch iterations per day!

 - Code quality of the submitted patches is atrocious, please run them through
   scripts/checkpatch.pl (and make sure they pass) to at least enable the reading 
   of them.

 - ... plus dozens of other details described in Documentation/SubmittingPatches.

Thanks,

	Ingo