linux-kernel - Re: [PATCH][rds-next] rds: make functions rds_info_from_znotifier and rds_message_zcopy_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b693b404-3c66-5c45-4610-e119956c8dff@oracle.com>
Date:   Sun, 11 Mar 2018 23:54:56 -0700
From:   "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
To:     Colin King <colin.king@...onical.com>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, rds-devel@....oracle.com
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][rds-next] rds: make functions rds_info_from_znotifier and
 rds_message_zcopy_from_user static

On 3/11/18 10:03 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Functions rds_info_from_znotifier and rds_message_zcopy_from_user are
> local to the source and do not need to be in global scope, so make them
> static.
> 
> Cleans up sparse warnins:
> net/rds/message.c:70:27: warning: symbol 'rds_info_from_znotifier' was
> not declared. Should it be static?
> net/rds/message.c:358:5: warning: symbol 'rds_message_zcopy_from_user'
> was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   net/rds/message.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>