linux-kernel - Re: [PATCH v7] staging: typec: handle vendor defined part and modify drp toggling flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFaeLdSBJ_SD9gtGbQsCchxQ03PBi3=6D4bjCpYrnm-xoRdvCg@mail.gmail.com>
Date:   Mon, 12 Mar 2018 14:57:14 +0800
From:   李書帆 <leechu729@...il.com>
To:     Jun Li <jun.li@....com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "greg@...ah.com" <greg@...ah.com>,
        "shufan_lee@...htek.com" <shufan_lee@...htek.com>,
        "cy_huang@...htek.com" <cy_huang@...htek.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: [PATCH v7] staging: typec: handle vendor defined part and modify
 drp toggling flow

Hi Jun,

2018-03-12 13:58 GMT+08:00 Jun Li <jun.li@....com>:
> Hi
>> -----Original Message-----
>> From: 李書帆 [mailto:leechu729@...il.com]
>> Sent: 2018年3月12日 13:22
>> To: Jun Li <jun.li@....com>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>;
>> heikki.krogerus@...ux.intel.com; linux@...ck-us.net; greg@...ah.com;
>> shufan_lee@...htek.com; cy_huang@...htek.com;
>> linux-kernel@...r.kernel.org; linux-usb@...r.kernel.org
>> Subject: Re: [PATCH v7] staging: typec: handle vendor defined part and modify
>> drp toggling flow
>>
>> Hi Jun,
>>
>>   Thank you.
>>
>> 2018-03-12 12:33 GMT+08:00 Jun Li <jun.li@....com>:
>> > Hi,
>> >
>> >> +static irqreturn_t _tcpci_irq(int irq, void *dev_id) {
>> >> +     struct tcpci *tcpci = dev_id;
>> >> +
>> >> +     return tcpci_irq(tcpci);
>> >> +}
>> >>
>> > ...
>> >
>> >> +     err = devm_request_threaded_irq(&client->dev, client->irq, NULL,
>> >> +                                     _tcpci_irq,
>> >>                                       IRQF_ONESHOT |
>> IRQF_TRIGGER_LOW,
>> >> -                                     dev_name(tcpci->dev), tcpci);
>> >> +                                     dev_name(&client->dev), chip);
>> >
>> > - dev_name(&client->dev), chip);
>> > + dev_name(&client->dev), chip->tcpci);
>> >
>> > Did you ever test this patch?
>> I've tested this patch with tcpci_rt1711h.c that will be sent out for reviewing in
>> the next patch after tcpci's modification is passed.
>> Because interrupt handler is registered in tcpci_rt1711h.c, here is the place I
>> didn't notice.
>
> Understood.
>
>> The interrupt handler for tcpci.c should be modified as following:
>>  static irqreturn_t _tcpci_irq(int irq, void *dev_id)  {
>> -       struct tcpci *tcpci = dev_id;
>> +       struct tcpci_chip *chip = dev_id;
>>
>> -       return tcpci_irq(tcpci);
>> +       return tcpci_irq(chip->tcpci);
>>  }
>>
>
> Either way is OK to fix it.
> You may send out your v8 and notify Greg to drop your v7 version.
>
> Jun Li

May I add you in the Reported-by list?

-- 
Best Regards,
書帆