linux-kernel - Re: [PATCH] staging: wilc1000: use pre-defined macro is_broadcast_ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Mar 2018 15:08:08 +0530
From:   "<Hariprasath Elango>" <hariprasath.elango@...il.com>
To:     hariprasath.elango@...il.com
Cc:     aditya.shankar@...rochip.com, vbabu3@...teon.com,
        Hari Prasath <hgujulan@...teon.com>,
        Ganesh Krishna <ganesh.krishna@...rochip.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-wireless@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wilc1000: use pre-defined macro
 is_broadcast_ether_addr

On Mon, Mar 12, 2018 at 02:17:15PM +0530, hariprasath.elango@...il.com wrote:
> From: Hari Prasath <hgujulan@...teon.com>
> 
> Use the kernel pre-defined macro is_broadcast_ether_addr() instead of
> doing a memcmp here.
> 
> Signed-off-by: Hari Prasath <hgujulan@...teon.com>
> ---
>  drivers/staging/wilc1000/linux_mon.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c
> index bbdfc7a..f93f411 100644
> --- a/drivers/staging/wilc1000/linux_mon.c
> +++ b/drivers/staging/wilc1000/linux_mon.c
> @@ -27,7 +27,6 @@ static struct net_device *wilc_wfi_mon; /* global monitor netdev */
>  
>  static u8 srcadd[6];
>  static u8 bssid[6];
> -static u8 broadcast[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
>  /**
>   *  @brief      WILC_WFI_monitor_rx
>   *  @details
> @@ -193,7 +192,7 @@ static netdev_tx_t WILC_WFI_mon_xmit(struct sk_buff *skb,
>  
>  	skb_pull(skb, rtap_len);
>  
> -	if (skb->data[0] == 0xc0 && (!(memcmp(broadcast, &skb->data[4], 6)))) {
> +	if (skb->data[0] == 0xc0 && is_broadcast_ether_addr(&skb->data[4])) {
>  		skb2 = dev_alloc_skb(skb->len + sizeof(struct wilc_wfi_radiotap_cb_hdr));
>  		if (!skb2)
>  			return -ENOMEM;
> -- 
> 2.10.0.GIT
> 

Kindly discard this patch. I will send a v2 as sent mail ID and
signed-off are not matching