linux-kernel - Re: 答复: [PATCH] Delete some unusefull operations for centaur CPU/platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180312094609.46sw3ojaa7sw3mee@gmail.com>
Date:   Mon, 12 Mar 2018 10:46:09 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     David Wang <DavidWang@...oxin.com>,
        "len.brown@...el.com" <len.brown@...el.com>,
        "pavel@....cz" <pavel@....cz>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
        "linux-pm@...nel.org" <linux-pm@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Bruce Chang (VAS)" <BruceChang@...-alliance.com>,
        "Cooper Yan(BJ-RD)" <CooperYan@...oxin.com>,
        "Qiyuan Wang(BJ-RD)" <QiyuanWang@...oxin.com>,
        Benjamin Pan <BenjaminPan@...tech.com>,
        Luke Lin <LukeLin@...cpu.com>,
        "Tim Guo(BJ-RD)" <TimGuo@...oxin.com>,
        "Cobe Chen(BJ-RD)" <CobeChen@...oxin.com>,
        "Jiangbo Wang(BJ-RD)" <JiangboWang@...oxin.com>
Subject: Re: 答复: [PATCH] Delete some
 unusefull operations for centaur CPU/platform


* Rafael J. Wysocki <rjw@...ysocki.net> wrote:

> On Monday, March 12, 2018 9:40:33 AM CET Ingo Molnar wrote:
> > 
> > * David Wang <DavidWang@...oxin.com> wrote:
> > 
> > > [David] pr->flags.has_cst means BIOS define valid C state table.  And at lease 
> > > define 2 entries. On all centaur platform which support C3, this condition is 
> > > always true.
> > 
> > > [David] Just as the following comment said, we need not execute WBINVD and 
> > > ARB_DISABLE/ARB_ENABLE when entering C3 if bm_check=1 and bm_control=0.  This 
> > > logic is valid for all platform not only for Centaur, I think.
> > 
> > Ok, fair enough!
> 
> Well, I still have this one queued up as cpuidle material.
> 
> I can drop it if you want to take it instead.

No need to drop it, it looks good to me!

Thanks,

	Ingo