linux-kernel - Re: [PATCH v9] mmc: Export host capabilities to debugfs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39d886ff-7bfe-5ef9-5d51-4ff1eaa55278@mentor.com>
Date:   Mon, 12 Mar 2018 15:57:12 +0530
From:   Harish Jenny K N <harish_kandiga@...tor.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        <ulf.hansson@...aro.org>, <linus.walleij@...aro.org>,
        <adrian.hunter@...el.com>, <shawn.lin@...k-chips.com>,
        <avri.altman@....com>
CC:     <linux-mmc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <Vladimir_Zapolskiy@...tor.com>
Subject: Re: [PATCH v9] mmc: Export host capabilities to debugfs.



On Monday 12 March 2018 03:37 PM, Andy Shevchenko wrote:
> On Mon, 2018-03-12 at 10:01 +0530, Harish Jenny K N wrote:
>> This patch exports the host capabilities to debugfs
>>
>> This idea of sharing host capabilities over debugfs
>> came up from Abbas Raza <Abbas_Raza@...tor.com>
>> Earlier discussions:
>> https://lkml.org/lkml/2018/3/5/357
>> https://www.spinics.net/lists/linux-mmc/msg48219.html
>>
> Address below minors and, FWIW, take mine
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Thanks.

>
>> +	for_each_set_bit(bit, (const unsigned long *)&caps,
>> BITS_PER_LONG)
>> +	for_each_set_bit(bit, (const unsigned long *)&caps2,
>> BITS_PER_LONG)
> Explicit casting is not needed anymore in both cases.
>

I will address these.
Before sending new patch , I would like to inform that I have been sending this patch with the following checkpatch warning, just to keep it same as other usages of debugfs_create_file in the drivers/mmc/core/debugfs.c file.

WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'.

Do I need to address this or keep it same as S_IRUSR ?

Thanks,
Harish Jenny K N