linux-kernel - RE: [PATCH v9] mmc: Export host capabilities to debugfs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR04MB10854C79897A80023EF37F76FCD30@DM5PR04MB1085.namprd04.prod.outlook.com>
Date:   Mon, 12 Mar 2018 10:45:53 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Harish Jenny K N <harish_kandiga@...tor.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "shawn.lin@...k-chips.com" <shawn.lin@...k-chips.com>
CC:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Vladimir_Zapolskiy@...tor.com" <Vladimir_Zapolskiy@...tor.com>
Subject: RE: [PATCH v9] mmc: Export host capabilities to debugfs.



> -----Original Message-----
> From: Andy Shevchenko [mailto:andriy.shevchenko@...ux.intel.com]
> Sent: Monday, March 12, 2018 12:08 PM
> To: Harish Jenny K N <harish_kandiga@...tor.com>; ulf.hansson@...aro.org;
> linus.walleij@...aro.org; adrian.hunter@...el.com; shawn.lin@...k-
> chips.com; Avri Altman <Avri.Altman@....com>
> Cc: linux-mmc@...r.kernel.org; linux-kernel@...r.kernel.org;
> Vladimir_Zapolskiy@...tor.com
> Subject: Re: [PATCH v9] mmc: Export host capabilities to debugfs.
> 
> On Mon, 2018-03-12 at 10:01 +0530, Harish Jenny K N wrote:
> > This patch exports the host capabilities to debugfs
> >
> > This idea of sharing host capabilities over debugfs came up from Abbas
> > Raza <Abbas_Raza@...tor.com> Earlier discussions:
> > https://lkml.org/lkml/2018/3/5/357
> > https://www.spinics.net/lists/linux-mmc/msg48219.html
> >
> 
> Address below minors and, FWIW, take mine
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> > +	for_each_set_bit(bit, (const unsigned long *)&caps,
> > BITS_PER_LONG)
> 
> > +	for_each_set_bit(bit, (const unsigned long *)&caps2,
> > BITS_PER_LONG)
> 
> Explicit casting is not needed anymore in both cases.
Also maybe use sizeof(mmc_host_capabilities) instead of BITS_PER_LONG?


> 
> --
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Intel Finland Oy