linux-kernel - Re: [PATCH v9] mmc: Export host capabilities to debugfs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <540fef96-aa2f-e6c3-467d-bc1d021dd55b@mentor.com>
Date:   Mon, 12 Mar 2018 16:46:50 +0530
From:   Harish Jenny K N <harish_kandiga@...tor.com>
To:     Avri Altman <Avri.Altman@....com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "shawn.lin@...k-chips.com" <shawn.lin@...k-chips.com>
CC:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Vladimir_Zapolskiy@...tor.com" <Vladimir_Zapolskiy@...tor.com>
Subject: Re: [PATCH v9] mmc: Export host capabilities to debugfs.



On Monday 12 March 2018 04:15 PM, Avri Altman wrote:
>
>> -----Original Message-----
>> From: Andy Shevchenko [mailto:andriy.shevchenko@...ux.intel.com]
>> Sent: Monday, March 12, 2018 12:08 PM
>> To: Harish Jenny K N <harish_kandiga@...tor.com>; ulf.hansson@...aro.org;
>> linus.walleij@...aro.org; adrian.hunter@...el.com; shawn.lin@...k-
>> chips.com; Avri Altman <Avri.Altman@....com>
>> Cc: linux-mmc@...r.kernel.org; linux-kernel@...r.kernel.org;
>> Vladimir_Zapolskiy@...tor.com
>> Subject: Re: [PATCH v9] mmc: Export host capabilities to debugfs.
>>
>> On Mon, 2018-03-12 at 10:01 +0530, Harish Jenny K N wrote:
>>> This patch exports the host capabilities to debugfs
>>>
>>> This idea of sharing host capabilities over debugfs came up from Abbas
>>> Raza <Abbas_Raza@...tor.com> Earlier discussions:
>>> https://lkml.org/lkml/2018/3/5/357
>>> https://www.spinics.net/lists/linux-mmc/msg48219.html
>>>
>> Address below minors and, FWIW, take mine
>>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>>
>>> +	for_each_set_bit(bit, (const unsigned long *)&caps,
>>> BITS_PER_LONG)
>>> +	for_each_set_bit(bit, (const unsigned long *)&caps2,
>>> BITS_PER_LONG)
>> Explicit casting is not needed anymore in both cases.
> Also maybe use sizeof(mmc_host_capabilities) instead of BITS_PER_LONG?

You mean sizeof(caps) and not sizeof(mmc_host_capabilities) . Right ?


Thanks,
Harish Jenny K N