linux-kernel - Re: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <872c1fca-df7c-84c1-e14b-0f7d60d0bafe@theobroma-systems.com>
Date:   Tue, 13 Mar 2018 18:53:43 +0100
From:   Jakob Unterwurzacher <jakob.unterwurzacher@...obroma-systems.com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
Cc:     Martin Elshuber <martin.elshuber@...obroma-systems.com>,
        Philipp Tomsich <philipp.tomsich@...obroma-systems.com>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        linux-can@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN
 devices

On 13.03.18 18:44, Marc Kleine-Budde wrote:
> On 03/13/2018 06:35 PM, Jakob Unterwurzacher wrote:
> 
> [...]
> 
> Please mark all multibyte values going over the USB as either le or be.

This is documented in can_ucan_protocol.rst,

     All multi-byte integers are encoded as Little Endian.

but it's probably worth mentioning here as well.

> 
> Please use standard 'net' comment style:
> 
>  /* this is a multiline
>   * comment
>   */
> 
>> +	struct ucan_ctl_cmd_start cmd_start;
>> +	/***************************************************
>> +	 * Setup Bittiming
>> +	 * bmRequest == UCAN_COMMAND_SET_BITTIMING
>> +	 ***************************************************/

Understood.

Thanks,
Jakob