linux-kernel - Re: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180313130051.43b087dd@ajaysk-VirtualBox>
Date:   Tue, 13 Mar 2018 13:00:51 +0530
From:   Ajay Singh <ajay.kathat@...rochip.com>
To:     <hariprasath.elango@...il.com>, <linux-kernel@...r.kernel.org>
CC:     <aditya.shankar@...rochip.com>, <vbabu3@...teon.com>,
        Ganesh Krishna <ganesh.krishna@...rochip.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-wireless@...r.kernel.org>, <devel@...verdev.osuosl.org>
Subject: Re: [PATCHv2] staging: wilc1000: use pre-defined macro
 is_broadcast_ether_addr


Reviewed-by: Ajay Singh <ajay.kathat@...rochip.com>

On Mon, 12 Mar 2018 15:09:03 +0530
<hariprasath.elango@...il.com> wrote:

> From: HariPrasath Elango <hariprasath.elango@...il.com>
>

Please avoid use of 'From' tag specially when there is only one
'Signed-off-by' tag and its same.

> Use the kernel pre-defined macro is_broadcast_ether_addr() instead of
> doing a memcmp here.
> 
> Signed-off-by: HariPrasath Elango <hariprasath.elango@...il.com>
> ---

Regards,
Ajay