linux-kernel - Re: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180313095816.GA1656@kroah.com>
Date:   Tue, 13 Mar 2018 10:58:16 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Ajay Singh <ajay.kathat@...rochip.com>
Cc:     hariprasath.elango@...il.com, linux-kernel@...r.kernel.org,
        devel@...verdev.osuosl.org, vbabu3@...teon.com,
        linux-wireless@...r.kernel.org,
        Ganesh Krishna <ganesh.krishna@...rochip.com>,
        aditya.shankar@...rochip.com
Subject: Re: [PATCHv2] staging: wilc1000: use pre-defined macro
 is_broadcast_ether_addr

On Tue, Mar 13, 2018 at 01:00:51PM +0530, Ajay Singh wrote:
> 
> Reviewed-by: Ajay Singh <ajay.kathat@...rochip.com>
> 
> On Mon, 12 Mar 2018 15:09:03 +0530
> <hariprasath.elango@...il.com> wrote:
> 
> > From: HariPrasath Elango <hariprasath.elango@...il.com>
> >
> 
> Please avoid use of 'From' tag specially when there is only one
> 'Signed-off-by' tag and its same.

But the email client isn't putting the correct info in the email header,
so this line is needed.

And if it's redundant, not a problem, git handles it just fine, better
to be safe.

thanks,

greg k-h