linux-kernel - Re: [PATCH] video: fbdev: via: remove VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e3b270d-b615-e58c-fd6e-f677e7e892e8@embeddedor.com>
Date:   Mon, 12 Mar 2018 22:29:27 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Emil Velikov <emil.l.velikov@...il.com>,
        Eric Engestrom <eric.engestrom@...tec.com>
Cc:     Florian Tobias Schandinat <FlorianSchandinat@....de>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-fbdev <linux-fbdev@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>,
        kernel-hardening@...ts.openwall.com,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Subject: Re: [PATCH] video: fbdev: via: remove VLA usage



On 03/09/2018 05:02 AM, Emil Velikov wrote:
> On 9 March 2018 at 10:59, Eric Engestrom <eric.engestrom@...tec.com> wrote:
>> On Thursday, 2018-03-08 11:39:49 -0600, Gustavo A. R. Silva wrote:
>>> In preparation to enabling -Wvla, remove VLA usage.
>>>
>>> Also, fixed as part of the directive to remove all VLAs from
>>> the kernel: https://lkml.org/lkml/2018/3/7/621
>>>
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>>
>> Sorry for my reply on v1, I missed that Emil already replied to another
>> post of the same patch (side note on that, making use of `-vX` and
>> `--in-reply-to` helps track the evolution of patches)
>>

Yep. I know. It is just that some people prefer vX in a new thread. 
Anyway, I will take this into account for the next time.

>> This looks good to me:
>> Reviewed-by: Eric Engestrom <eric.engestrom@...tec.com>
>>
> Same here
> Reviewed-by: Emil Velikov <emil.velikov@...labora.com>
> 
> -Emil
> 

Thanks for reviewing it, guys.
-- 
Gustavo A. R. Silva