linux-kernel - Re: [PATCH 2/2] x86/mm: remove pointless checks in vmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1521056327.2693.138.camel@hpe.com>
Date:   Wed, 14 Mar 2018 19:38:51 +0000
From:   "Kani, Toshi" <toshi.kani@....com>
To:     "tglx@...utronix.de" <tglx@...utronix.de>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "gratian.crisan@...com" <gratian.crisan@...com>,
        "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "luto@...nel.org" <luto@...nel.org>, "bp@...en8.de" <bp@...en8.de>
Subject: Re: [PATCH 2/2] x86/mm: remove pointless checks in vmalloc_fault

On Wed, 2018-03-14 at 20:27 +0100, Thomas Gleixner wrote:
> On Tue, 13 Mar 2018, Toshi Kani wrote:
> 
> > vmalloc_fault() sets user's pgd or p4d from the kernel page table.
> > Once it's set, all tables underneath are identical. There is no point
> > of following the same page table with two separate pointers and makes
> > sure they see the same with BUG().
> > 
> > Remove the pointless checks in vmalloc_fault(). Also rename the kernel
> > pgd/p4d pointers to pgd_k/p4d_k so that their names are consistent in
> > the file.
> 
> I have no idea to which branch this might apply. The first patch applies
> cleanly on linus head, but this one fails in hunk #2 on everything I
> tried. Can you please check?

Sorry for the trouble. The patches are based on linus head. I just tried
and they applied clean to me... 

Thanks,
-Toshi