linux-kernel - Re: [PATCH 2/2] x86/mm: remove pointless checks in vmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1803142054390.1946@nanos.tec.linutronix.de>
Date:   Wed, 14 Mar 2018 20:56:41 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     "Kani, Toshi" <toshi.kani@....com>
cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "gratian.crisan@...com" <gratian.crisan@...com>,
        "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "luto@...nel.org" <luto@...nel.org>, "bp@...en8.de" <bp@...en8.de>
Subject: Re: [PATCH 2/2] x86/mm: remove pointless checks in vmalloc_fault

On Wed, 14 Mar 2018, Kani, Toshi wrote:
> On Wed, 2018-03-14 at 20:27 +0100, Thomas Gleixner wrote:
> > On Tue, 13 Mar 2018, Toshi Kani wrote:
> > 
> > > vmalloc_fault() sets user's pgd or p4d from the kernel page table.
> > > Once it's set, all tables underneath are identical. There is no point
> > > of following the same page table with two separate pointers and makes
> > > sure they see the same with BUG().
> > > 
> > > Remove the pointless checks in vmalloc_fault(). Also rename the kernel
> > > pgd/p4d pointers to pgd_k/p4d_k so that their names are consistent in
> > > the file.
> > 
> > I have no idea to which branch this might apply. The first patch applies
> > cleanly on linus head, but this one fails in hunk #2 on everything I
> > tried. Can you please check?
> 
> Sorry for the trouble. The patches are based on linus head. I just tried
> and they applied clean to me... 

Hmm. Looks like I tried on the wrong branch. Nevertheless, 1/2 is queued in
urgent, but 2/2 will go through tip/x86/mm which already has changes in
that area causing the patch to fail. I just merged x86/urgent into x86/mm
and pushed it out. Can you please rebase 2/2 on top of that bracnh and
resend ?

Thanks,

	tglx