linux-kernel - RE: [PATCH v2]PCI: hv: fix PCI-BUS domainID corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Mar 2018 19:56:13 +0000
From:   "Michael Kelley (EOSG)" <Michael.H.Kelley@...rosoft.com>
To:     Sridhar Pitchai <Sridhar.Pitchai@...rosoft.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>
CC:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Jake Oshins <jakeo@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Dexuan Cui <decui@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2]PCI: hv: fix PCI-BUS domainID corruption

> -----Original Message-----
> From: Sridhar Pitchai
> Sent: Wednesday, March 14, 2018 11:08 AM
> To: Lorenzo Pieralisi <lorenzo.pieralisi@....com>; Michael Kelley (EOSG)
> <Michael.H.Kelley@...rosoft.com>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>; Jake Oshins <jakeo@...rosoft.com>; Haiyang
> Zhang <haiyangz@...rosoft.com>; Stephen Hemminger <sthemmin@...rosoft.com>; Dexuan
> Cui <decui@...rosoft.com>; KY Srinivasan <kys@...rosoft.com>;
> devel@...uxdriverproject.org; linux-pci@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH v2]PCI: hv: fix PCI-BUS domainID corruption
> 
>     Whenever PCI bus is added, HyperV guarantees the BUS id is unique. Even with
>     that when a first device is added to the bus, it overrides bus domain ID with
>     the device serial number. Sometime this can result in BUS ID not being unique.
>     In this case, when PCI_BUS and a device added to the bus, even before the PCI
>     BUS is added to kernel, the first device tends to overwrite the domain ID with
>     0. Since there exists a PCI bus with domain ID 0 already the PCI bus addition
>     fails. This patch make sure when a device is added to a bus, it never updated
>     the bus domain ID. Since we have the transparent SRIOV mode now, the short VF
>     device name is no longer needed.
> 
>     Fixes: 4a9b0933bdfc("PCI:hv:Use device serial number as PCI domain")
>     Cc: stable@...r.kernel.org
>     Signed-off-by: Sridhar Pitchai <srpitcha@...rosoft.com>
>     ---

Reviewed-by: Michael Kelley <mikelley@...rosoft.com>