lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Mar 2018 00:08:51 -0500 From: Timur Tabi <timur@...eaurora.org> To: Sinan Kaya <okaya@...eaurora.org>, netdev@...r.kernel.org, sulrich@...eaurora.org Cc: linux-arm-msm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, Jeff Kirsher <jeffrey.t.kirsher@...el.com>, intel-wired-lan@...ts.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 7/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs On 3/13/18 10:20 PM, Sinan Kaya wrote: > +/* Assumes caller has executed a write barrier to order memory and device > + * requests. > + */ > static inline void ixgbevf_write_tail(struct ixgbevf_ring *ring, u32 value) > { > - writel(value, ring->tail); > + writel_relaxed(value, ring->tail); > } Why not put the wmb() in this function, or just get rid of the wmb() in the rest of the file and keep this as writel? That way, you can avoid the comment and the risk that comes with it. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
Powered by blists - more mailing lists