lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Mar 2018 08:51:46 -0500 From: Josh Poimboeuf <jpoimboe@...hat.com> To: Ingo Molnar <mingo@...nel.org> Cc: tip-bot for Andy Whitcroft <tipbot@...or.com>, linux-tip-commits@...r.kernel.org, hpa@...or.com, dave.hansen@...ux.intel.com, arjan@...ux.intel.com, dwmw@...zon.co.uk, gregkh@...uxfoundation.org, torvalds@...ux-foundation.org, apw@...onical.com, bp@...en8.de, luto@...nel.org, dan.j.williams@...el.com, tglx@...utronix.de, linux-kernel@...r.kernel.org, dwmw2@...radead.org, peterz@...radead.org Subject: Re: [tip:x86/pti] x86/speculation, objtool: Annotate indirect calls/jumps for objtool on 32-bit kernels On Wed, Mar 14, 2018 at 02:39:43PM +0100, Ingo Molnar wrote: > > * Josh Poimboeuf <jpoimboe@...hat.com> wrote: > > > On Wed, Mar 14, 2018 at 05:28:01AM -0700, tip-bot for Andy Whitcroft wrote: > > > Commit-ID: a14bff131108faf50cc0cf864589fd71ee216c96 > > > Gitweb: https://git.kernel.org/tip/a14bff131108faf50cc0cf864589fd71ee216c96 > > > Author: Andy Whitcroft <apw@...onical.com> > > > AuthorDate: Wed, 14 Mar 2018 11:24:27 +0000 > > > Committer: Ingo Molnar <mingo@...nel.org> > > > CommitDate: Wed, 14 Mar 2018 13:24:31 +0100 > > > > > > x86/speculation, objtool: Annotate indirect calls/jumps for objtool on 32-bit kernels > > > > > > In the following commit: > > > > > > 9e0e3c5130e9 ("x86/speculation, objtool: Annotate indirect calls/jumps for objtool") > > > > > > ... we added annotations for CALL_NOSPEC/JMP_NOSPEC on 64-bit x86 kernels, > > > but we did not annotate the 32-bit path. > > > > > > Annotate it similarly. > > > > This patch has no effect because objtool only supports 64-bit kernels. > > Yeah, indeed - but it's still a good change for completeness, right? Yeah, it's fine. Objtool won't use it, but I suppose it makes the code less surprising and more consistent for humans. -- Josh
Powered by blists - more mailing lists