linux-kernel - Re: [PATCH v4 09/24] fpga: dfl-pci: add enumeration for feature devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Mar 2018 09:48:35 -0500
From:   Alan Tull <atull@...nel.org>
To:     Wu Hao <hao.wu@...el.com>
Cc:     Moritz Fischer <mdf@...nel.org>, linux-fpga@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-api@...r.kernel.org, "Kang, Luwei" <luwei.kang@...el.com>,
        "Zhang, Yi Z" <yi.z.zhang@...el.com>,
        Tim Whisonant <tim.whisonant@...el.com>,
        Enno Luebbers <enno.luebbers@...el.com>,
        Shiva Rao <shiva.rao@...el.com>,
        Christopher Rauer <christopher.rauer@...el.com>,
        Xiao Guangrong <guangrong.xiao@...ux.intel.com>
Subject: Re: [PATCH v4 09/24] fpga: dfl-pci: add enumeration for feature devices

On Wed, Mar 14, 2018 at 12:21 AM, Wu Hao <hao.wu@...el.com> wrote:

>> > +
>> > +       drvdata->cdev = cdev;
>> > +
>> > +enum_info_free_exit:
>> > +       fpga_enum_info_free(info);
>>
>> This is the only place I saw fpga_enum_info_free being called.
>
> It doesn't need to keep the enumeration inforamtion data structure once
> the enumeration done, so in the driver, it always did fpga_enum_info_free
> once fpga_enumerate_feature_devs(info) returned in this function. so
> no need to consider it in other places per my understanding. : )
>
> Thanks
> Hao
>

Oh yes I see!  I was looking right at it and didn't see it!  Thanks
for the clarification.

Alan