linux-kernel - Re: + headers-untangle-kmemleakh-from-mmh-fix.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180314075055.353f2d975defb2af34f65d2b@linux-foundation.org>
Date:   Wed, 14 Mar 2018 07:50:55 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     linux-kernel@...r.kernel.org, rdunlap@...radead.org,
        sfr@...b.auug.org.au
Subject: Re: + headers-untangle-kmemleakh-from-mmh-fix.patch added to -mm
 tree

On Wed, 14 Mar 2018 13:17:04 +0100 Michal Hocko <mhocko@...nel.org> wrote:

> > --- a/security/keys/big_key.c~headers-untangle-kmemleakh-from-mmh-fix
> > +++ a/security/keys/big_key.c
> > @@ -18,6 +18,7 @@
> >  #include <linux/err.h>
> >  #include <linux/scatterlist.h>
> >  #include <linux/random.h>
> > +#include <linux/vmalloc.h>
> >  #include <keys/user-type.h>
> >  #include <keys/big_key-type.h>
> >  #include <crypto/aead.h>
> 
> My build test battery says we need also this one, m32r complains
> otherwise for allmodconfig.
> 
> >From 5c3f7a041df707417532dd64b1d71fc29b24c0fe Mon Sep 17 00:00:00 2001
> From: Michal Hocko <mhocko@...e.com>
> Date: Wed, 14 Mar 2018 13:15:49 +0100
> Subject: [PATCH] headers-untangle-kmemleakh-from-mmh-fix-fix
> 
> m32r allmodconfig complains with
> security/integrity/digsig.c:146:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
>   vfree(data);
>   ^
> Signed-off-by: Michal Hocko <mhocko@...e.com>
> ---
>  security/integrity/digsig.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c
> index 6f9e4ce568cd..9bb0a7f2863e 100644
> --- a/security/integrity/digsig.c
> +++ b/security/integrity/digsig.c
> @@ -18,6 +18,7 @@
>  #include <linux/cred.h>
>  #include <linux/key-type.h>
>  #include <linux/digsig.h>
> +#include <linux/vmalloc.h>
>  #include <crypto/public_key.h>
>  #include <keys/system_keyring.h>

hm, current linux-next.patch already has this change.  What happened here?