linux-kernel - Re: [PATCH v3] EDAC, sb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Mar 2018 13:23:27 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] EDAC, sb_edac: Remove VLA usage



On 03/14/2018 01:03 PM, Borislav Petkov wrote:

[..]

>>   
>>   struct interleave_pkg {
>>   	unsigned char start;
>> @@ -1899,7 +1904,7 @@ static int get_memory_error_data(struct mem_ctl_info *mci,
>>   	int			n_rir, n_sads, n_tads, sad_way, sck_xch;
>>   	int			sad_interl, idx, base_ch;
>>   	int			interleave_mode, shiftup = 0;
>> -	unsigned		sad_interleave[pvt->info.max_interleave];
> 
> Where's the hunk removing ->max_interleave ?
> 

Oh. I forgot to remove it.

I already sent v4: https://patchwork.kernel.org/patch/10283289/

Thanks
--
Gustavo