linux-kernel - Re: [PATCH] drivers: base: add description for .coredump() callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5AAA3DC5.4070101@broadcom.com>
Date:   Thu, 15 Mar 2018 10:32:53 +0100
From:   Arend van Spriel <arend.vanspriel@...adcom.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: base: add description for .coredump() callback

On 3/14/2018 10:06 AM, Arend van Spriel wrote:
> On 2/9/2018 10:13 AM, Arend van Spriel wrote:
>> Commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") added
>> a new callback in struct device_driver, but not a kerneldoc description
>> so here it is.
>
> Hi Greg,
>
> Revisiting the header file I notice this patch is not yet applied. I am
> pretty sure I got an automated email from you regarding the merge
> window, but nothing else so did this one slip the cracks?

Hi Greg,

As I am touching this in follow-up patch, can we just drop this one? I 
will be posting a couple of new patch assuming it is fine to drop this. 
Let me know how you want to handle this.

Regards,
Arend

> Regards,
> Arend
>
>> Fixes: 3c47d19ff4dc ("drivers: base: add coredump driver ops")
>> Signed-off-by: Arend van Spriel <aspriel@...il.com>
>> ---
>>   include/linux/device.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/device.h b/include/linux/device.h
>> index b093405..0b32a42 100644
>> --- a/include/linux/device.h
>> +++ b/include/linux/device.h
>> @@ -256,6 +256,7 @@ enum probe_type {
>>    *        automatically.
>>    * @pm:        Power management operations of the device which matched
>>    *        this driver.
>> + * @coredump:    Called through sysfs to initiate a device coredump.
>>    * @p:        Driver core's private data, no one other than the driver
>>    *        core can touch this.
>>    *
>>
>