linux-kernel - Re: [PATCH] Documentation/CodingStyle: Add an example for braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zi39ljni.fsf@intel.com>
Date:   Thu, 15 Mar 2018 12:26:09 +0200
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Gary R Hook <gary.hook@....com>, linux-doc@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, corbet@....net
Subject: Re: [PATCH] Documentation/CodingStyle: Add an example for braces

On Wed, 14 Mar 2018, Gary R Hook <gary.hook@....com> wrote:
> Add another example of required braces when using a compound statement in
> a loop.
>
> Signed-off-by: Gary R Hook <gary.hook@....com>
> ---
>  Documentation/process/coding-style.rst |    9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
> index a20b44a40ec4..d98deb62c400 100644
> --- a/Documentation/process/coding-style.rst
> +++ b/Documentation/process/coding-style.rst
> @@ -200,6 +200,15 @@ statement; in the latter case use braces in both branches:
>  		otherwise();
>  	}
>  
> +Also, use braces when a loop contains more than a single simple statement:

Personally, I'd not limit this to loops.

	if (condition) {
        	if (another_condition)
                	action();
        }

You could argue the existing rule already covers these cases by
excluding selection and iteration statements from the "single statement"
in "Do not unnecessarily use braces where a single statement will do."

BR,
Jani.

> +
> +.. code-block:: c
> +
> +	while (condition) {
> +		if (test)
> +			do_something();
> +	}
> +
>  3.1) Spaces
>  ***********
>  
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-doc" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Jani Nikula, Intel Open Source Technology Center