linux-kernel - Re: [PATCH v2 1/2] soc: imx: gpcv2: Do not pass static memory as platform data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHQ1cqHdtN7xjmAcQvKDknnGKAP0pRgk6pcFrzOiSew9=Z9GQg@mail.gmail.com>
Date:   Thu, 15 Mar 2018 06:00:06 -0700
From:   Andrey Smirnov <andrew.smirnov@...il.com>
To:     Shawn Guo <shawnguo@...nel.org>
Cc:     Fabio Estevam <fabio.estevam@....com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Stefan Agner <stefan@...er.ch>,
        Lucas Stach <l.stach@...gutronix.de>
Subject: Re: [PATCH v2 1/2] soc: imx: gpcv2: Do not pass static memory as
 platform data

On Wed, Mar 14, 2018 at 8:08 PM, Shawn Guo <shawnguo@...nel.org> wrote:
> On Thu, Feb 08, 2018 at 02:47:10PM +0800, Shawn Guo wrote:
>> On Mon, Jan 22, 2018 at 07:07:47AM -0800, Andrey Smirnov wrote:
>> > Platform device core assumes the ownership of dev.platform_data as
>> > well as that it is dynamically allocated and it will try to kfree it
>> > as a part of platform_device_release(). Change the code to pass
>> > kzalloc'ed chunk of memory instead of a pointer to a static memory to
>> > avoid causing a BUG() when calling platform_device_put().
>> >
>> > The problem can be reproduced by artificially enabling the error path
>> > of platform_device_add() call (around line 357).
>> >
>> > Note that this change also allows us to constify imx7_pgc_domains,
>> > since we no longer need to be able to modify it.
>> >
>> > Cc: Shawn Guo <shawnguo@...nel.org>
>> > Cc: Stefan Agner <stefan@...er.ch>
>> > Cc: Lucas Stach <l.stach@...gutronix.de>
>> > Cc: linux-arm-kernel@...ts.infradead.org
>> > Cc: linux-kernel@...r.kernel.org
>> > Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
>>
>> Applied both, thanks.
>
> I decided to drop these two patches.  Triggered by Fabio's patch on top
> of you changes, I just took another look at them, and found that
> platform_device_add_data() can help us do the same thing in a nicer way.
>

Shawn:

I am slightly confused by your phrasing. Are you:

a) saying that you dropped my patches in favor of your own that use
platform_device_add_data()

or

b) asking me to convert my patches to use platform_device_add_data()?

Just trying to figure out if any action on my part is necessary.

Thanks,
Andrey Smirnov