linux-kernel - Re: [PATCHv2 3/7] driver, misc: add Intel Stratix10 service layer driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 15 Mar 2018 17:48:36 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     richard.gong@...ux.intel.com
Cc:     catalin.marinas@....com, will.deacon@....com, dinguyen@...nel.org,
        robh+dt@...nel.org, mark.rutland@....com, atull@...nel.org,
        mdf@...nel.org, arnd@...db.de,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-fpga@...r.kernel.org,
        yves.vandervennet@...ux.intel.com,
        Richard Gong <richard.gong@...el.com>
Subject: Re: [PATCHv2 3/7] driver, misc: add Intel Stratix10 service layer
 driver

On Thu, Mar 01, 2018 at 06:19:31PM -0600, richard.gong@...ux.intel.com wrote:
> +EXPORT_SYMBOL_GPL(request_svc_channel_byname);

All of your global symbols should have the same prefix, not a verb.  So
this should be:
	svc_channel_request_by_name(), right?

> +EXPORT_SYMBOL_GPL(free_svc_channel);

svc_channel_free()?

> +EXPORT_SYMBOL_GPL(intel_svc_send);

Wait, why doesn't the first ones have "intel_svc" in them?

What is the difference here?

Should they all just have "intel_svc_" as the prefix?

Stick to one thing for all exported functions/variables please, it's the
only way we can attempt to keep our namespace "sane".

Also, why would a 'misc' driver be exporting things that something else
uses?  Why not just put this in the fpga directory next to the users of
this code?

thanks,

greg k-h