linux-kernel - Re: [PATCH] PCI: tegra: mark PM functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180315164927.GA31871@ulmo>
Date:   Thu, 15 Mar 2018 17:49:27 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Manikanta Maddireddy <mmaddireddy@...dia.com>,
        Stephen Warren <swarren@...dia.com>,
        Vidya Sagar <vidyas@...dia.com>, linux-tegra@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: tegra: mark PM functions as __maybe_unused

On Thu, Mar 15, 2018 at 05:18:39PM +0100, Arnd Bergmann wrote:
> The new PM support causes a warning when CONFIG_PM is disabled:
> 
> drivers/pci/host/pci-tegra.c:2482:12: error: 'tegra_pcie_pm_resume' defined but not used [-Werror=unused-function]
>  static int tegra_pcie_pm_resume(struct device *dev)
> drivers/pci/host/pci-tegra.c:2463:12: error: 'tegra_pcie_pm_suspend' defined but not used [-Werror=unused-function]
>  static int tegra_pcie_pm_suspend(struct device *dev)
> 
> Marking the functions as __maybe_unused lets the compiler drop them
> silently instead.
> 
> Fixes: b90b44154023 ("PCI: tegra: Add power management support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/pci/host/pci-tegra.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)