linux-kernel - Re: [PATCH v6 16/20] clk: add support for clocks provided by SCMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <152124137391.242365.17144416413429914606@swboyd.mtv.corp.google.com>
Date:   Fri, 16 Mar 2018 16:02:53 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     ALKML <linux-arm-kernel@...ts.infradead.org>,
        DTML <devicetree@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Sudeep Holla <sudeep.holla@....com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Turquette <mturquette@...libre.com>,
        Alexey Klimov <klimov.linux@...il.com>,
        Sudeep Holla <sudeep.holla@....com>, linux-clk@...r.kernel.org
Subject: Re: [PATCH v6 16/20] clk: add support for clocks provided by SCMI

Quoting Sudeep Holla (2018-02-23 08:23:46)
> diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c
> new file mode 100644
> index 000000000000..1e4d7a57779b
> --- /dev/null
> +++ b/drivers/clk/clk-scmi.c
> +                       hws[idx] = &sclk->hw;
> +               }
> +       }
> +
> +       return of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_data);

devm_of_clk_add_hw_provider?

> +}
> +
> +static void scmi_clocks_remove(struct scmi_device *sdev)
> +{
> +       struct device *dev = &sdev->dev;
> +       struct device_node *np = dev->of_node;
> +
> +       of_clk_del_provider(np);
> +}
> +

Drop?

You can keep my acked-by otherwise.