linux-kernel - Re: [PATCH v6 16/20] clk: add support for clocks provided by SCMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b5a56f7-ff0d-dde2-097b-bf245971e8a6@arm.com>
Date:   Tue, 20 Mar 2018 12:08:51 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     Stephen Boyd <sboyd@...nel.org>,
        ALKML <linux-arm-kernel@...ts.infradead.org>,
        DTML <devicetree@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Sudeep Holla <sudeep.holla@....com>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Turquette <mturquette@...libre.com>,
        Alexey Klimov <klimov.linux@...il.com>,
        linux-clk@...r.kernel.org
Subject: Re: [PATCH v6 16/20] clk: add support for clocks provided by SCMI



On 16/03/18 23:02, Stephen Boyd wrote:
> Quoting Sudeep Holla (2018-02-23 08:23:46)
>> diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c
>> new file mode 100644
>> index 000000000000..1e4d7a57779b
>> --- /dev/null
>> +++ b/drivers/clk/clk-scmi.c
>> +                       hws[idx] = &sclk->hw;
>> +               }
>> +       }
>> +
>> +       return of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_data);
> 
> devm_of_clk_add_hw_provider?
> 

Thanks for noticing this, I wasn't aware of it's addition. This patch
predates that :(

>> +}
>> +
>> +static void scmi_clocks_remove(struct scmi_device *sdev)
>> +{
>> +       struct device *dev = &sdev->dev;
>> +       struct device_node *np = dev->of_node;
>> +
>> +       of_clk_del_provider(np);
>> +}
>> +
> 
> Drop?
> 

Sure, I will have to do these changes as add-on patch as this original
patch is already queued in ARM SoC tree for v4.17

> You can keep my acked-by otherwise.
> 

Thanks.

-- 
Regards,
Sudeep